Zystkmt

I have written code to count the continuous ones in an array or you can use binary string for convenience. Any solution using the binary string is acceptable.

My Solution is:

#include<bits/stdc++.h>

using namespace std;

#define MAX 100000

int main()

{

  int n,q,k,count;

  string str;

  cin>>n>>q>>k;

  bitset<MAX>s,c;

  //inserting bits in array

  for(int i=0;i<n;i++)

  {

    int temp;

    cin>>temp;

    s[i]=temp;

   }

   cin>>str;

  for(int i=0;i<q;i++)

  {

     //making duplicate bitset

     c=s;

     if(str[i]=='?')

      {

         count=0;

         while(c!=0) 

         { 

            //using bitmask to count maximum no of continuous 1's-O(1's bit)

            c=(c&(c<<1)); 

            count++; 

          }

      if(count>k)

         cout<<k<<"n";

      else

         cout<<count<<"n";

   }

   else

   {

       //shifting each bit to right and updating first bit with previous last

      // bit

       bool lb=s[n-1];

       s=s>>1;

       s[n-1]=lb;

    }

  }

}

<bits/stdc++.h> (like everything in your compiler's bits/ subtree) is not a standard header and therefore not portable. Even if you're willing to sacrifice portability, it's a poor choice, as it will slow compilation down compared to simply including what you use.

using namespace std; is poor practice. It makes your code less clear, and it may even silently change its meaning.

Don't use the preprocessor to name constants. Use a properly scoped, strongly typed C++ constant:

constexpr std::size_t max = 100000;

When using input streams, always check that operations succeed before using their results.

Variable names should be more descriptive. I have no idea what n, q, and k are supposed to be storing. In fact, these names are so useless that I gave up reading at this point - it's not at all clear what this is supposed to be doing.

• When you post code to be reviewed:
  
  
  
  
  • If your code ask for input, provide a set of valid an invalids inputs
  
  
  • If your code output a result, express expected.
  
  
  
  


• Since you present your code, it may be interesting to embrace a coding standard. You do not pay taxes on written characters. Do not be afraid to use spaces to improve readability.


• 
  Don't include <bits/stdc++.h>`:
  
  
  
  
  • It's not a standard header. If you try to compile your code with MSVC, he will complain that he can't find him.
  
  
  • Even if you use only GCC, it would include so much unnecessary things that your compilation time will increase considerably.
  
  
  • Instead, explicitly includes all header needed.
  
  
  
  


• 
  Don't use using namespace std; :
  
  
  
  
  • Although it's "safe" to use it in some place (e.g. implementation files), as long as you are not familiar with the features of c ++, try to avoid it.
  
  
  • It led to a world of name collisions. (best case)
  
  
  • It's source of silent errors and weird bugs. (worst case)
  
  
  • If typing std:: is so tedious for you, try to import only truncated namespaces. ( eg using namespace std::string;).
  
  
  • If importing nested namespaces still too awful for you, try to do it inside a restricted scope (eg a functions) and not in global scope.
  
  
  
  


• 
  Don't use preprocessors to defines constants values, instead use const variable.


• 
  Chose good name for variables. what's n, q or k mean? They are int, but? And for s or c, we know they are bitset<MAX>, but nothing more.


• 
  Write expressive code, in which your intentions are clearly stated.


• 
  Don't declare more than one variable at a time. It led to error, mainly working with pointer or initialization.


• 
  Always initialize a variable when you declare it.


• Extract the code into reusable functions , short as possible, and that operate a reduced and well defined number of statements. (see Single responsibility principle). (eg, a function that asks the user to enter an input, reads them and returns them)


• If you ask user to input some values, really ask (tell to user what he have to write)


• When you read values from user input, consider it ill-formed, so check for validity. Here you don't check after getting the int's. Futhermore, you don't check the length of the string and but access it by indexes, etc.


• The main function should return an integer.

Don't declare multiple variables on a single line. it is error prone and more difficult to read.

int n,q,k,count;

should be:

int n;

int q;

int k;

int count;

Not sure what I mean by error prone?

int* n,q,k,count;

How many pointers do you have? one. only n would be a pointer in this declaration.

Let your operators breathe. The lack of whitespace makes your code harder to read.

for(int i = 0; i < n; i++)

  {

    int temp;

    cin >> temp;

    s[i] = temp;

  }

this is a little easier to distinguish.

Prefer prefix to postfix

Use more consistent indentation. I had to read the code three times just to realize that the scope braces didn't line up with each other. I almost flagged to close because

for ()

{

}

else

{}

would be broken, and that's how your braces line up horizontally.